-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date dependency #543
Comments
As far as I can tell, that's wrong. There are several dependencies across modules, and the documentation should make that explicit. |
It does... but not there. If you look at https://github.com/jquery/globalize#2-cldr-content this becomes more apparent. For a visual representation of what module depends on what, take a look at here |
It's still not explicitly stated anywhere. That's a nice tool @johnnyreilly, but it wasn't the first place I looked. And my other point was that the number module must be loaded first, or the date module throws an error. |
It may not be clear from the tool but the order in which files are listed is the order in which are required. But yeah, the docs could perhaps be a little clearer. Do you have a suggestion? A docs PR wouldn't take long to turn around... |
According to the Pick the modules you need section in the main readme it sound like each module is independent of other modules.
I created this demo to format a date...
number.js
isn't needed, but it is loaded afterdate.js
and this error appears in the console:which corresponds to this line: https://github.com/jquery/globalize/blob/master/src/date/format-properties.js#L25
Just to confirm my suspicions, this demo loads
number.js
beforedate.js
and it works without any problems.I should probably open a new issue for this, but would you consider including one big Globalize file that contains all the modules?
The text was updated successfully, but these errors were encountered: