Selectmenu: Code review #492

Closed
wants to merge 292 commits into
from
This pull request is big! We’re only showing the most recent 250 commits.
Commits on Oct 9, 2011
  1. @fnagel
Commits on Oct 10, 2011
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
Commits on Oct 11, 2011
  1. @fnagel
  2. @fnagel
  3. @fnagel
Commits on Oct 12, 2011
  1. @fnagel

    Selectmenu: changed to _delay

    fnagel committed Oct 12, 2011
  2. @fnagel
  3. @fnagel
  4. @fnagel
Commits on Oct 17, 2011
  1. @fnagel
  2. @fnagel

    Selectmenu: fixed IE width calc

    fnagel committed Oct 17, 2011
  3. @fnagel

    Selectmenu: fixed disabled option

    fnagel committed Oct 17, 2011
  4. @fnagel
  5. @fnagel

    Selectmenu: code cleanup

    fnagel committed Oct 17, 2011
Commits on Oct 19, 2011
  1. @jzaefferer
Commits on Oct 27, 2011
  1. @fnagel
Commits on Nov 2, 2011
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
Commits on Nov 18, 2011
  1. @jzaefferer
  2. @jzaefferer

    Whitespace cleanup

    jzaefferer committed Nov 18, 2011
  3. @jzaefferer
Commits on Nov 21, 2011
  1. @fnagel
  2. @fnagel

    Selectmenu: fixed jQuery version

    fnagel committed Nov 21, 2011
  3. @fnagel
  4. @fnagel
  5. @fnagel
Commits on Nov 24, 2011
  1. @jzaefferer
  2. @jzaefferer

    Upgrade jQuery to 1.7.1.

    jzaefferer committed Nov 24, 2011
  3. @danwellman
Commits on Nov 25, 2011
  1. @danwellman
Commits on Nov 28, 2011
  1. @fnagel
  2. @danwellman
Commits on Nov 30, 2011
  1. @kborchers
Commits on Dec 1, 2011
  1. @danwellman
  2. @danwellman
  3. @danwellman

    Selectmenu: removed duplicates from options unit tests and added new …

    danwellman committed Dec 1, 2011
    …options and events tests
  4. @danwellman
  5. @kborchers
  6. @fnagel
  7. @fnagel
  8. @fnagel
Commits on Dec 12, 2011
  1. @danwellman
  2. @danwellman
Commits on Dec 13, 2011
  1. @danwellman
Commits on Dec 15, 2011
  1. @kborchers
  2. @kborchers
Commits on Dec 22, 2011
  1. @fnagel

    Selectmenu: improved button event handling, Home/End and Page Up/Page…

    fnagel committed Dec 22, 2011
    … Down keys work now, THX to John
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
Commits on Dec 23, 2011
  1. @fnagel
  2. @kborchers
Commits on Jan 11, 2012
  1. @jzaefferer
  2. @fnagel

    Merge pull request #536 from danwellman/selectmenu

    fnagel committed Jan 11, 2012
    Selectmenu: additional unit tests
  3. @fnagel
  4. @fnagel
Commits on Jan 12, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel

    Selectmenu: removed option value

    fnagel committed Jan 12, 2012
  4. @fnagel
  5. @fnagel
Commits on Jan 13, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
Commits on Jan 19, 2012
  1. @fnagel
  2. @fnagel
Commits on Jan 20, 2012
  1. @fnagel
Commits on Jan 22, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
  7. @fnagel
  8. @fnagel

    Selectmenu: minor improvements

    fnagel committed Jan 22, 2012
Commits on Jan 25, 2012
  1. @fnagel
Commits on Jan 26, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel

    Selectmenu: small follow up

    fnagel committed Jan 26, 2012
  4. @fnagel
Commits on Jan 27, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel

    Selectmenu: trim trailing spaces

    fnagel committed Jan 27, 2012
Commits on Feb 15, 2012
  1. @fnagel
Commits on Feb 21, 2012
  1. @jzaefferer
  2. @jzaefferer
  3. @jzaefferer

    Selectmenu: Reorder default demo to reduce the odd top-margin (still …

    jzaefferer committed Feb 21, 2012
    …needed to fully show the popup menu)
  4. @jzaefferer
  5. @jzaefferer
  6. @jzaefferer

    Selectmenu: Introduce menuWidget method, to get access to the menu el…

    jzaefferer committed Feb 21, 2012
    …ement. Fix various tests and simplify demos accordingly. Add comment about optgroup-click-handling.
  7. @fnagel
  8. @fnagel
  9. @fnagel
  10. @fnagel
  11. @fnagel
  12. @fnagel
Commits on Feb 23, 2012
  1. @fnagel
  2. @fnagel

    Selectmenu: fixed small typo

    fnagel committed Feb 23, 2012
  3. @fnagel
  4. @fnagel
Commits on Feb 24, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
Commits on Feb 25, 2012
  1. @fnagel

    Selectmenu: improve optgroup header event handling, fixed disabled it…

    fnagel committed Feb 25, 2012
    …em event handling, improve attribute handling on menu toggle, small improvements, clean-up
  2. @fnagel

    Selectmenu: merged _toggleButtonStyle with _toggleAttr method, remove…

    fnagel committed Feb 25, 2012
    …d incomplete dropdown _setOptions functionality
Commits on Feb 26, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel

    Selectmenu: remove unwanted Menu mouseover event, fixes problem with …

    fnagel committed Feb 26, 2012
    …selected item highlighting on menu open
  5. @fnagel
  6. @fnagel
  7. @fnagel
  8. @fnagel
Commits on Feb 28, 2012
  1. @fnagel
Commits on Mar 1, 2012
  1. @scottgonzalez
  2. @scottgonzalez
  3. @scottgonzalez
Commits on Mar 14, 2012
  1. @scottgonzalez
Commits on Mar 19, 2012
  1. @kborchers
  2. @kborchers

    Selectmenu: Add links to all menu items to be in line with what menu …

    kborchers committed Mar 19, 2012
    …expects and remove the extra space added to disabled items
Commits on Apr 1, 2012
  1. @fnagel
  2. @fnagel
Commits on May 14, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
Commits on May 16, 2012
  1. @fnagel

    Menu: Check that the event object is defined before checking type, in…

    fnagel committed May 16, 2012
    … conformance to revision e2a6cdd and in order to make Selectmenu work again
  2. @fnagel

    Selectmenu: make optgroups work again, needed because of Menu widget …

    fnagel committed May 16, 2012
    …changes (ui-menu-divider)
  3. @fnagel

    Selectmenu: trim trailing spaces

    fnagel committed May 16, 2012
  4. @fnagel
  5. @fnagel
  6. @fnagel
  7. @fnagel

    Selectmenu: Update unit tests

    fnagel committed May 16, 2012
  8. @fnagel
  9. @fnagel

    Selectmenu: trim trailing spaces

    fnagel committed May 16, 2012
Commits on May 24, 2012
  1. @fnagel
  2. @fnagel

    Merge with master

    fnagel committed May 24, 2012
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
Commits on May 31, 2012
  1. @fnagel
  2. @fnagel
Commits on Jul 12, 2012
  1. @fnagel
  2. @fnagel

    Selectmenu: changed _bind to _on

    fnagel committed Jul 12, 2012
  3. @fnagel
  4. @fnagel

    Selectmenu: trim trailing spaces

    fnagel committed Jul 12, 2012
  5. @fnagel
Commits on Jul 16, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel

    Selectmenu: follow-up to 'split core unit test for state synchronizat…

    fnagel committed Jul 16, 2012
    …ion in keydown and click'
Commits on Jul 17, 2012
  1. @scottgonzalez
Commits on Aug 11, 2012
  1. @fnagel
  2. @fnagel

    Selectmenu: remove unbind Menu document event to reset mouseHandled f…

    fnagel committed Aug 11, 2012
    …lag, related to revision b8ad711
  3. @fnagel

    Simplify licensing.

    fnagel committed Aug 11, 2012
Commits on Aug 30, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
Commits on Sep 4, 2012
  1. @fnagel
Commits on Oct 3, 2012
  1. @fnagel
  2. @fnagel
Commits on Oct 12, 2012
  1. @fnagel
Commits on Oct 15, 2012
  1. @robertbeuligmann
Commits on Oct 16, 2012
  1. @robertbeuligmann
Commits on Oct 19, 2012
  1. @jzaefferer
Commits on Oct 25, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
  7. @fnagel

    Selectmenu: hopefully fixed multiple a11y bugs (value is recognized b…

    fnagel committed Oct 25, 2012
    …y screenreader: in collapsed state, when selecting a value, on tab focus; label points to button now)
  8. @fnagel
  9. @fnagel

    Selectmenu: follow-up for menu, reset aria-activedescendant to select…

    fnagel committed Oct 25, 2012
    …ed item when menu is closed
Commits on Oct 26, 2012
  1. @fnagel
Commits on Oct 27, 2012
  1. @fnagel
Commits on Nov 10, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
Commits on Nov 12, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
Commits on Nov 13, 2012
  1. @fnagel

    Selectmenu tests: lint fixes

    fnagel committed Nov 13, 2012
  2. @fnagel
  3. @fnagel

    Selectmenu: lint fixes

    fnagel committed Nov 13, 2012
  4. @fnagel

    Selectmenu tests: lint fixes

    fnagel committed Nov 13, 2012
Commits on Nov 15, 2012
  1. @jzaefferer
  2. @jzaefferer
  3. @jzaefferer
  4. @jzaefferer
Commits on Nov 23, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
Commits on Nov 28, 2012
  1. @fnagel
  2. @fnagel

    Selectmenu: better position handling, fixes issue with wrong styles w…

    fnagel committed Nov 28, 2012
    …hen using custom positioning
Commits on Nov 29, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
  7. @fnagel
  8. @fnagel
  9. @fnagel
  10. @fnagel
  11. @fnagel
  12. @fnagel
  13. @fnagel
Commits on Dec 3, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
Commits on Dec 7, 2012
  1. @jzaefferer
Commits on Dec 9, 2012
  1. @jzaefferer

    Selectmenu: Remove colons from labels, annoying for screenreader-user…

    jzaefferer committed Dec 9, 2012
    …s. Cleanup whitespace.
  2. @jzaefferer
Commits on Dec 12, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel

    Selectmenu: fix comment typo

    fnagel committed Dec 12, 2012
  5. @fnagel

    Selectmenu tests: improve focus event test so its possible to test fo…

    fnagel committed Dec 12, 2012
    …r too much focus events from menu widget
  6. @fnagel

    Selectmenu: merge and explain if statements in Menu focus event, remo…

    fnagel committed Dec 12, 2012
    …ve unneeded Menu focus method call in open
  7. @fnagel

    Selectmenu: removed ugly workaround for IE9 to make sure the menu is …

    fnagel committed Dec 12, 2012
    …built on first focus
  8. @fnagel

    Selectmenu: revert change to text instead of html, otherwise the unic…

    fnagel committed Dec 12, 2012
    …ode special char wont be displayed
  9. @fnagel
Commits on Dec 13, 2012
  1. @fnagel
  2. @fnagel
Commits on Dec 14, 2012
  1. @fnagel
Commits on Dec 15, 2012
  1. @fnagel
  2. @fnagel
  3. @fnagel
  4. @fnagel
  5. @fnagel
  6. @fnagel
  7. @fnagel
  8. @fnagel

    Selectmenu: CGL and lint fixes

    fnagel committed Dec 15, 2012
Commits on Dec 16, 2012
  1. @fnagel

    Selectmenu: remove zIndex

    fnagel committed Dec 16, 2012