Skip to content

Commit

Permalink
Event: Update support comments for mouseenter/mouseleave implementation
Browse files Browse the repository at this point in the history
Custom mouseenter/mouseleave implementation was needed because of:
1. Safari 6 not implementing mouseenter/mouseleave at all.
2. Chrome sending mouseenter too often.

The second issue has been fixed in Chrome but exists now in Safari 7
(it's fixed in Safari 8) so we have to keep it for now, unfortunately.
  • Loading branch information
mgol committed Jul 27, 2015
1 parent 93bee47 commit 2792845
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -772,13 +772,10 @@ jQuery.Event.prototype = {
// so that event delegation works in jQuery.
// Do the same for pointerenter/pointerleave and pointerover/pointerout
//
// Support: Safari<7.0
// Safari doesn't support mouseenter/mouseleave at all.
//
// Support: Chrome 34+
// Mouseenter doesn't perform while left mouse button is pressed
// (and initiated outside the observed element)
// https://code.google.com/p/chromium/issues/detail?id=333868
// Support: Safari 7 only
// Safari sends mouseenter too often; see:
// https://code.google.com/p/chromium/issues/detail?id=470258
// for the description of the bug (it existed in older Chrome versions as well).
jQuery.each({
mouseenter: "mouseover",
mouseleave: "mouseout",
Expand Down

2 comments on commit 2792845

@mgol
Copy link
Member Author

@mgol mgol commented on 2792845 Jul 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jquery/core For a moment I thought we'll be able to finally rip out our custom mouseenter/mouseleave implementation... but no, Safari 7 needs it. :(

@markelog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon @mzgol soon :-)

Please sign in to comment.