Skip to content

Commit

Permalink
Adds post-install grunt hook
Browse files Browse the repository at this point in the history
  • Loading branch information
@fat @rwaldron
fat authored and rwaldron committed Jun 19, 2012
1 parent 7692ae4 commit 286c4d9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "jquery",
"title": "jQuery",
"main": "./dist/jquery.js",
"description": "New Wave JavaScript",
"version": "1.8.0pre",
"homepage": "http://jquery.com",
Expand Down Expand Up @@ -30,5 +31,8 @@
"grunt": ">=0.3.9",
"testswarm": "0.2.2"
},
"keywords": []
"keywords": [],
"scripts": {
"postinstall": "./node_modules/grunt/bin/grunt"
}
}

7 comments on commit 286c4d9

@Krinkle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing color codes to show up in the Jenkins console.

Exec:

npm install --color false
COMMIT=${GIT_COMMIT} grunt --no-color

That second command would be obsolete with this in package.json. Is there a way to translate the npm color option to grunt?

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second command won't be obsolete, as we need that enviroment variable to pass the commit hash. I don't really this what problem this change solves, but has unintended consequences.

@rwldrn any opinion on the matter?

@rwaldron
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzaefferer seems unfortunate, because setting "scripts" and its various callback hooks is pretty common - I think this is a deficiency of our system if there are problems.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pretty common", right, but does it matter here at all? I don't know how to fix this without reverting, as we can't pass anything from an npm install call to grunt.

@rwaldron
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we'll roll it back for now.

@fat sorry, but this is effing up our Jenkins/testswarm setup

@fat
Copy link
Contributor Author

@fat fat commented on 286c4d9 Jun 21, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzaefferer can't you just pass that --no-color param along... ./node_modules/grunt/bin/grunt --no-color ?

@rwldrn no big deal - would be nice tho

@fat
Copy link
Contributor Author

@fat fat commented on 286c4d9 Jun 21, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzaefferer ah never mind, miss read the environment variable bit

Please sign in to comment.