Fix #11021. There should be no mangling of the "hover" namespace.

jquery · Dec 14, 2011 · 4534db1 · 4534db1
1 parent 5798eab
commit 4534db1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/event.js b/src/event.js
@@ -2,7 +2,7 @@
 
 var rformElems = /^(?:textarea|input|select)$/i,
 	rtypenamespace = /^([^\.]*)?(?:\.(.+))?$/,
-	rhoverHack = /\bhover(\.\S+)?\b/,
+	rhoverHack = /(?:^|\s)hover(\.\S+)?\b/,
 	rkeyEvent = /^key/,
 	rmouseEvent = /^(?:mouse|contextmenu)|click/,
 	rfocusMorph = /^(?:focusinfocus|focusoutblur)$/,

diff --git a/test/unit/event.js b/test/unit/event.js
@@ -787,7 +787,7 @@ test("unbind(eventObject)", function() {
 });
 
 test("hover() and hover pseudo-event", function() {
-	expect(2);
+	expect(3);
 
 	var times = 0,
 		handler1 = function( event ) { ++times; },
@@ -810,6 +810,9 @@ test("hover() and hover pseudo-event", function() {
 		.on( "hovercraft", function() {
 			ok( false, "hovercraft is full of ills" );
 		})
+		.on( "click.hover.me.not", function( e ) {
+			equal( e.handleObj.namespace, "hover.me.not", "hover hack doesn't mangle namespaces" );
+		})
 		.bind("hover", function( e ) {
 			if ( e.type === "mouseenter" ) {
 				balance++;
@@ -819,6 +822,7 @@ test("hover() and hover pseudo-event", function() {
 				ok( false, "hover pseudo: unknown event type "+e.type );
 			}
 		})
+		.trigger("click")
 		.trigger("mouseenter")
 		.trigger("mouseleave")
 		.unbind("hover")