Permalink
Browse files

Release: remove sourcemap comment from all copies of minified file

Fixes gh-1707
  • Loading branch information...
timmywil committed Jan 30, 2015
1 parent e0673df commit a76c7812366e7e45ea29969db72d90261ef87af5
Showing with 15 additions and 9 deletions.
  1. +1 −1 Gruntfile.js
  2. +0 −6 build/release/cdn.js
  3. +13 −0 build/tasks/sourcemap.js
  4. +1 −2 package.json
View
@@ -161,7 +161,7 @@ module.exports = function( grunt ) {
grunt.registerTask( "test", [ "test_fast" ] );
// Short list as a high frequency watch task
grunt.registerTask( "dev", [ "build:*:*", "lint", "uglify", "dist:*" ] );
grunt.registerTask( "dev", [ "build:*:*", "lint", "uglify", "remove_map_comment", "dist:*" ] );
grunt.registerTask( "default", [ "dev", "test_fast", "compare_size" ] );
};
View
@@ -44,12 +44,6 @@ function makeReleaseCopies( Release ) {
"\"file\":\"" + unpathedFile.replace( /\.min\.map/, ".min.js" ) +
"\",\"sources\":[\"" + unpathedFile.replace( /\.min\.map/, ".js" ) + "\"]" );
fs.writeFileSync( releaseFile, text );
} else if ( /\.min\.js$/.test( releaseFile ) ) {
// Remove the source map comment; it causes way too many problems.
// Keep the map file in case DevTools allow manual association.
text = fs.readFileSync( builtFile, "utf8" )
.replace( /\/\/# sourceMappingURL=\S+/, "" );
fs.writeFileSync( releaseFile, text );
} else if ( builtFile !== releaseFile ) {
shell.cp( "-f", builtFile, releaseFile );
}
View
@@ -0,0 +1,13 @@
var fs = require( "fs" );
module.exports = function( grunt ) {
var minLoc = Object.keys( grunt.config( "uglify.all.files" ) )[ 0 ];
grunt.registerTask( "remove_map_comment", function() {
// Remove the source map comment; it causes way too many problems.
// The map file is still generated for manual associations
// https://github.com/jquery/jquery/issues/1707
var text = fs.readFileSync( minLoc, "utf8" )
.replace( /\/\/# sourceMappingURL=\S+/, "" );
fs.writeFileSync( minLoc, text );
});
};
View
@@ -35,7 +35,7 @@
"grunt-cli": "0.1.13",
"grunt-compare-size": "0.4.0",
"grunt-contrib-jshint": "0.10.0",
"grunt-contrib-uglify": "0.6.0",
"grunt-contrib-uglify": "0.7.0",
"grunt-contrib-watch": "0.6.1",
"grunt-git-authors": "2.0.1",
"grunt-jscs-checker": "0.8.1",
@@ -61,7 +61,6 @@
"Tests",
"Build",
"Release",
"Core",
"Ajax",
"Attributes",

0 comments on commit a76c781

Please sign in to comment.