Skip to content
Permalink
Browse files

If .attr() is run on no elements undefined should be returned (as sho…

…uld be the case when no attribute is found). Fixes #6012.
  • Loading branch information
jeresig committed Feb 13, 2010
1 parent 83a044f commit abcc1a76ee2a6733177b2cd104bc32cee5443ec4
Showing with 5 additions and 2 deletions.
  1. +1 −1 src/core.js
  2. +4 −1 test/unit/attributes.js
@@ -799,7 +799,7 @@ function access( elems, key, value, exec, fn, pass ) {
}

// Getting an attribute
return length ? fn( elems[0], key ) : null;
return length ? fn( elems[0], key ) : undefined;
}

function now() {
@@ -4,7 +4,7 @@ var bareObj = function(value) { return value; };
var functionReturningObj = function(value) { return (function() { return value; }); };

test("attr(String)", function() {
expect(28);
expect(30);

// This one sometimes fails randomly ?!
equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
@@ -61,6 +61,9 @@ test("attr(String)", function() {
select.appendChild( optgroup );

equals( jQuery(option).attr("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );

ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
});

if ( !isLocal ) {

0 comments on commit abcc1a7

Please sign in to comment.
You can’t perform that action at this time.