Event: Trigger checkbox and radio click events identically

Fixes gh-3423 Closes gh-3494
jquery · Jan 19, 2017 · b442aba · b442aba
1 parent 3c89329
commit b442aba
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/event.js b/src/event.js
@@ -3,12 +3,12 @@ define( [
 	"./var/document",
 	"./var/documentElement",
 	"./var/rnothtmlwhite",
+	"./var/rcheckableType",
 	"./var/slice",
 	"./data/var/dataPriv",
-
 	"./core/init",
 	"./selector"
-], function( jQuery, document, documentElement, rnothtmlwhite, slice, dataPriv ) {
+], function( jQuery, document, documentElement, rnothtmlwhite, rcheckableType, slice, dataPriv ) {
 
 "use strict";
 
@@ -474,9 +474,11 @@ jQuery.event = {
 		},
 		click: {
 
-			// For checkbox, fire native event so checked state will be right
+			// For checkable types, fire native event so checked state will be right
 			trigger: function() {
-				if ( this.type === "checkbox" && this.click && jQuery.nodeName( this, "input" ) ) {
+				if ( rcheckableType.test( this.type ) &&
+					this.click && jQuery.nodeName( this, "input" ) ) {
+
 					this.click();
 					return false;
 				}

diff --git a/src/manipulation.js b/src/manipulation.js
@@ -2,8 +2,8 @@ define( [
 	"./core",
 	"./var/concat",
 	"./var/push",
+	"./var/rcheckableType",
 	"./core/access",
-	"./manipulation/var/rcheckableType",
 	"./manipulation/var/rtagName",
 	"./manipulation/var/rscriptType",
 	"./manipulation/wrapMap",
@@ -21,8 +21,8 @@ define( [
 	"./traversing",
 	"./selector",
 	"./event"
-], function( jQuery, concat, push, access,
+], function( jQuery, concat, push, rcheckableType,
-	rcheckableType, rtagName, rscriptType,
+	access, rtagName, rscriptType,
 	wrapMap, getAll, setGlobalEval, buildFragment, support,
 	dataPriv, dataUser, acceptData, DOMEval ) {
 

diff --git a/src/serialize.js b/src/serialize.js
@@ -1,6 +1,6 @@
 define( [
 	"./core",
-	"./manipulation/var/rcheckableType",
+	"./var/rcheckableType",
 	"./core/init",
 	"./traversing", // filter
 	"./attributes/prop"

diff --git a/src/manipulation/var/rcheckableType.js → src/var/rcheckableType.js b/src/manipulation/var/rcheckableType.js → src/var/rcheckableType.js