New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply same fix to radio buttons as for checkbox #3423
Comments
Yes, we appear to have a problem in Line 477 in f18ca7b
using this.type === "checkbox" instead of rcheckableType.test( this.type ) .
|
Hi there. I think we understand what you mean, but would you mind providing a test-case on http://jsbin.com/ or on similar resource? So it would be clear what behaviour you expect |
Such test case will also be necessary for a PR. Would you like to work on this, @mbest? |
Here is the jsbin that was linked in the Knockout issue: http://jsbin.com/yinare/4/edit?html,js,output |
This will be backed out due to the regression seen here. We will re-land with a fix for that regression in 3.3. |
Also see #1367 |
Seems the same issue would apply to |
Right, but that's not a regression since 3.1.1. We plan to address that as well in 3.3. |
@gibson042 is working on this, but it will not make it in the 3.3 release. |
(cherry picked from commit b442aba) Ref jquerygh-3494 Fixes jquerygh-3423
PR: #4279 |
(cherry picked from commit b442aba) Ref jquerygh-3494 Fixes jquerygh-3423
See https://bugs.jquery.com/ticket/3827 and 1fb2f92
This fix should also include
radio
buttons. Currently if you use jQuery to trigger a click on a radio button, event handlers get called before thechecked
state is updated. The release notes for 1.9.1 when the above change was included say it was changed for radio buttons even though it wasn't.The text was updated successfully, but these errors were encountered: