Fix #10984. Use origType when unbinding via the event object.

jquery · Dec 14, 2011 · c584ce4 · rwaldron · Dec 14, 2011 · c584ce4
1 parent 2a63b98
commit c584ce4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/event.js b/src/event.js
@@ -922,7 +922,7 @@ jQuery.fn.extend({
 			// ( event )  dispatched jQuery.Event
 			var handleObj = types.handleObj;
 			jQuery( types.delegateTarget ).off(
-				handleObj.namespace? handleObj.type + "." + handleObj.namespace : handleObj.type,
+				handleObj.namespace ? handleObj.origType + "." + handleObj.namespace : handleObj.origType,
 				handleObj.selector,
 				handleObj.handler
 			);

diff --git a/test/unit/event.js b/test/unit/event.js
@@ -2521,7 +2521,7 @@ test(".on and .off", function() {
 });
 
 test("special bind/delegate name mapping", function() {
-	expect( 6 );
+	expect( 7 );
 
 	jQuery.event.special.slap = {
 		bindType: "click",
@@ -2561,6 +2561,8 @@ test("special bind/delegate name mapping", function() {
 		delegateType: "click",
 		handle: function( event ) {
 			equal( event.handleObj.origType, "gutfeeling", "got a gutfeeling" );
+			// Need to call the handler since .one() uses it to unbind
+			return event.handleObj.handler.call( this , event );
 		}
 	};
 
@@ -2579,6 +2581,13 @@ test("special bind/delegate name mapping", function() {
 		.trigger( "gutfeeling" )
 		.remove();
 
+	// Ensure .one() events are removed after their maiden voyage
+	jQuery( '<p>Gut Feeling</p>' )
+		.one( "gutfeeling", jQuery.noop )
+		.trigger( "gutfeeling" )	// This one should 
+		.trigger( "gutfeeling" )	// This one should not
+		.remove();
+
 	delete jQuery.event.special.gutfeeling;
 });