Only call jQuery(this) when needed. Close gh-1260.

jquery · May 9, 2013 · c9267ab · c9267ab
1 parent 47f56f1
commit c9267ab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.mailmap b/.mailmap
@@ -33,6 +33,7 @@ Isaac Z. Schlueter <i@izs.me>
 Ismail Khair <ismail.khair@gmail.com>
 James Burke <jrburke@gmail.com>
 James Padolsey <cla@padolsey.net> <jamespadolsey@gmail.com>
+Jason Bedard <jason+jquery@jbedard.ca> <github@jbedard.ca>
 Jay Merrifield <fracmak@gmail.com>
 Jay Merrifield <fracmak@gmail.com> <jmerrifiel@gannett.com>
 Jean Boussier <jean.boussier@gmail.com>

diff --git a/AUTHORS.txt b/AUTHORS.txt
@@ -167,3 +167,4 @@ Michał Gołębiowski <m.goleb@gmail.com>
 Steven Benner <admin@stevenbenner.com>
 Li Xudong <istonelee@gmail.com>
 Renato Oliveira dos Santos <ros3@cin.ufpe.br>
+Jason Bedard <jason+jquery@jbedard.ca>
diff --git a/src/attributes.js b/src/attributes.js
@@ -182,15 +182,14 @@ jQuery.fn.extend({
 		isFunction = jQuery.isFunction( value );
 
 		return this.each(function( i ) {
-			var val,
-				self = jQuery(this);
+			var val;
 
 			if ( this.nodeType !== 1 ) {
 				return;
 			}
 
 			if ( isFunction ) {
-				val = value.call( this, i, self.val() );
+				val = value.call( this, i, jQuery( this ).val() );
 			} else {
 				val = value;
 			}