-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move clearing the support vars to before the offset doc ready call in…
… case the offset tests are run synchronously. Fixes #10737. - Adding a test for this would probably slow the manipulation tests significantly, but it's simple enough.
- Loading branch information
Showing
1 changed file
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -253,6 +253,12 @@ jQuery.support = (function() { | |
} | ||
} | ||
|
||
testElement.innerHTML = ""; | ||
testElementParent.removeChild( testElement ); | ||
|
||
// Null connected elements to avoid leaks in IE | ||
testElement = fragment = select = opt = body = marginDiv = div = input = null; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
timmywil
Author
Member
|
||
|
||
// Run fixed position tests at doc ready to avoid a crash | ||
// related to the invisible body in IE8 | ||
jQuery(function() { | ||
|
@@ -311,12 +317,6 @@ jQuery.support = (function() { | |
jQuery.extend( support, offsetSupport ); | ||
}); | ||
|
||
testElement.innerHTML = ""; | ||
testElementParent.removeChild( testElement ); | ||
|
||
// Null connected elements to avoid leaks in IE | ||
testElement = fragment = select = opt = body = marginDiv = div = input = null; | ||
|
||
return support; | ||
})(); | ||
|
||
|
1 comment
on commit d589709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay, this bug bit me today.
Shouldn't testElementParent also be cleared here?