Skip to content

Commit

Permalink
Remove moot second argument from slice.call()
Browse files Browse the repository at this point in the history
The zeroes were added to fix http://bugs.jquery.com/ticket/4942 but those browsers are no longer supported.
  • Loading branch information
sindresorhus authored and dmethvin committed Apr 5, 2012
1 parent 22ad872 commit d5ee856
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/core.js
Expand Up @@ -200,7 +200,7 @@ jQuery.fn = jQuery.prototype = {
},

toArray: function() {
return slice.call( this, 0 );
return slice.call( this );
},

// Get the Nth element in the matched element set OR
Expand Down
6 changes: 3 additions & 3 deletions src/deferred.js
Expand Up @@ -102,7 +102,7 @@ jQuery.extend({

// Deferred helper
when: function( firstParam ) {
var args = sliceDeferred.call( arguments, 0 ),
var args = sliceDeferred.call( arguments ),
i = 0,
length = args.length,
pValues = new Array( length ),
Expand All @@ -114,15 +114,15 @@ jQuery.extend({
promise = deferred.promise();
function resolveFunc( i ) {
return function( value ) {
args[ i ] = arguments.length > 1 ? sliceDeferred.call( arguments, 0 ) : value;
args[ i ] = arguments.length > 1 ? sliceDeferred.call( arguments ) : value;
if ( !( --count ) ) {
deferred.resolveWith( deferred, args );
}
};
}
function progressFunc( i ) {
return function( value ) {
pValues[ i ] = arguments.length > 1 ? sliceDeferred.call( arguments, 0 ) : value;
pValues[ i ] = arguments.length > 1 ? sliceDeferred.call( arguments ) : value;
deferred.notifyWith( promise, pValues );
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/event.js
Expand Up @@ -386,7 +386,7 @@ jQuery.event = {

var handlers = ( (jQuery._data( this, "events" ) || {} )[ event.type ] || []),
delegateCount = handlers.delegateCount,
args = [].slice.call( arguments, 0 ),
args = [].slice.call( arguments ),
run_all = !event.exclusive && !event.namespace,
special = jQuery.event.special[ event.type ] || {},
handlerQueue = [],
Expand Down

0 comments on commit d5ee856

Please sign in to comment.