Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery.fn.jquery might indicate compat #2269

Closed
mgol opened this issue May 6, 2015 · 4 comments
Closed

jQuery.fn.jquery might indicate compat #2269

mgol opened this issue May 6, 2015 · 4 comments
Assignees
@timmywil
Labels
1.x-only Build wontfix

Comments

@mgol
Copy link
Member

mgol commented May 6, 2015

To be in line with #1862, could jQuery.fn.jquery on compat be 3.0.0-pre+compat instead of current 3.0.0-pre?
@timmywil
Copy link
Member

timmywil commented May 6, 2015

+1, we'll just need to drop the suffix during the release process.

@timmywil timmywil added the Build label May 6, 2015
@timmywil timmywil added this to the 3.0.0 milestone May 6, 2015
@timmywil
Copy link
Member

timmywil commented May 6, 2015

Actually, no we won't. :)

@timmywil timmywil self-assigned this May 6, 2015
timmywil added a commit to timmywil/jquery that referenced this issue May 6, 2015
@timmywil
Build: append "+compat" to tag version and jQuery.fn.jquery
b79a22f 
Fixes jquerygh-2269
@timmywil timmywil mentioned this issue May 6, 2015
Closed
@timmywil
Copy link
Member

timmywil commented May 6, 2015

I noticed that I had the tag suffix wrong in build.js. I've updated that too.

@mgol mgol added the 1.x-only label May 7, 2015
timmywil added a commit that referenced this issue May 7, 2015
@timmywil
Build: append "+compat" to tag version and jQuery.fn.jquery
d18b645 
Fixes gh-2269
Close gh-2270
@timmywil timmywil closed this as completed May 7, 2015
@mgol
Copy link
Member Author

mgol commented Nov 3, 2015

We're not releasing compat anymore and this commit is irrelevant to 1.12 so I'm removing the milestone & adding the wontfix label.

@mgol mgol removed this from the 3.0.0 milestone Nov 3, 2015
@mgol mgol added the wontfix label Nov 3, 2015
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
1.x-only Build wontfix
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timmywil @mgol