New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include instruction for developing with amd #2714

Closed
markelog opened this Issue Nov 13, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@markelog
Member

markelog commented Nov 13, 2015

AMD mode in qunit test suite could be extremely useful when developing jQuery, i.e. without waiting on the grunt watch results on direct grunt build command.

I think we should include this in our README

@markelog markelog added the Docs label Nov 13, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Nov 13, 2015

Member

Good idea. Could be something like...

When developing jQuery, it can useful to run tests in AMD mode so the distribution files do not need to be rebuilt for the test suite to reflect recent changes. When viewing the QUnit test page, click "Load with AMD".

Member

timmywil commented Nov 13, 2015

Good idea. Could be something like...

When developing jQuery, it can useful to run tests in AMD mode so the distribution files do not need to be rebuilt for the test suite to reflect recent changes. When viewing the QUnit test page, click "Load with AMD".

@timmywil timmywil added this to the 3.0.0 milestone Nov 13, 2015

@timmywil timmywil self-assigned this Nov 16, 2015

timmywil added a commit to timmywil/jquery that referenced this issue Nov 16, 2015

Docs: add a note about loading source with AMD
- Moves the note about the watch task and the note about
  loading with AMD to their own section under
  "Test Suite Tips"

Fixes gh-2714
@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Nov 16, 2015

Member

Rather than the README, I included it along with similar notes in CONTRIBUTING.

Member

timmywil commented Nov 16, 2015

Rather than the README, I included it along with similar notes in CONTRIBUTING.

@timmywil timmywil closed this in e0c25ab Nov 17, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.