Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery leaks detached DOM #3018

Closed
jakwuh opened this issue Mar 26, 2016 · 1 comment
Closed

jQuery leaks detached DOM #3018

jakwuh opened this issue Mar 26, 2016 · 1 comment
Assignees
@markelog
Labels
Has Pull Request Support
Milestone
3.0.0

Comments

@jakwuh
Copy link

jakwuh commented Mar 26, 2016

I've noticed that in css/support.js there is a created DOM element, which is referenced then in function computeStyleTests. Because of it this DOM will never be removed.
Is it the way as it should be?
@markelog
Copy link
Member

Hardly a "leak", but yeah, this could be improved.

markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016
@markelog
Support: improve support properties computation
b84fd61 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes jquerygh-3018
markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016
@markelog
Support: improve support properties computation
0465e69 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes jquerygh-3018
@timmywil timmywil added this to the 3.0.0 milestone Mar 28, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markelog markelog

Labels
Has Pull Request Support
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@timmywil @markelog @jakwuh