New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery leaks detached DOM #3018

Closed
jakwuh opened this Issue Mar 26, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@jakwuh

jakwuh commented Mar 26, 2016

I've noticed that in css/support.js there is a created DOM element, which is referenced then in function computeStyleTests. Because of it this DOM will never be removed.
Is it the way as it should be?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Mar 28, 2016

Member

Hardly a "leak", but yeah, this could be improved.

Member

markelog commented Mar 28, 2016

Hardly a "leak", but yeah, this could be improved.

@markelog markelog added the Support label Mar 28, 2016

markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016

Support: improve support properties computation
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes gh-3018

markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016

Support: improve support properties computation
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes gh-3018

@timmywil timmywil added this to the 3.0.0 milestone Mar 28, 2016

@markelog markelog closed this in 44cb97e Mar 28, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.