Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate camelCasing logic between Data & CSS #3355

Closed
mgol opened this issue Oct 12, 2016 · 10 comments · Fixed by #4365
Closed

Separate camelCasing logic between Data & CSS #3355

mgol opened this issue Oct 12, 2016 · 10 comments · Fixed by #4365
Assignees
@mgol
Labels
Behavior Change Data Has Pull Request
Milestone
4.0.0

Comments

@mgol
Copy link
Member

mgol commented Oct 12, 2016 •
edited
Loading

Description

jQuery.camelCase contains a CSS-only quirk that replaces -ms- to ms-. This quirk is needed only in the CSS module and yet the data module uses it as well, making elem.data('-moz-a', 'b') create an MozA key and elem.data('-ms-a', 'b') - an msA key. Those use cases should be separated.

Due to needed breaking changes this is 4.0 material.

P.S. It would be best to resolve #3384 first.

EDIT: Description edited as part of this ticket has been separated to #3384.

Link to test case

https://jsfiddle.net/zmfvwak7/1/
@mgol mgol added this to the 4.0.0 milestone Oct 12, 2016
@mgol mgol self-assigned this Oct 12, 2016
@mgol mgol removed the Needs review label Oct 24, 2016
@markelog
Copy link
Member

markelog commented Oct 27, 2016 •
edited
Loading

This is a core method, if it requires changes in others places you don't really need other labels for this issue, I would argue that it would be more confusing and unconventional

@markelog
Copy link
Member

Also, did you create corresponding issues in docs and migrate repos?

@mgol
Copy link
Member Author

mgol commented Oct 27, 2016

@markelog This issue is not only about hiding jQuery.camelCase but also about fixes in camelCase handling in the data module so IMO it makes sense to double-label. Maybe the Effects label is not needed here.

@mgol mgol removed the Effects label Oct 27, 2016
@mgol
Copy link
Member Author

mgol commented Oct 27, 2016

I haven't reported those issues yet. I'll do it later.

@markelog
Copy link
Member

Sounds like two issues to me – one for hiding another to fix... aaaam something, so i'm like not sure what you want to fix

@markelog
Copy link
Member

markelog commented Oct 27, 2016 •
edited
Loading

Another argument for dividing those issue is that it would be easier for external contributors (since they already helped with that kind of issues before), so they could handle a hiding thing hence my reminder about creating other issues, whereas "fixing"... something doesn't have a really clear sequence of actions, at least to me, so it might be harder to them to tackle it

@mgol
Copy link
Member Author

mgol commented Oct 27, 2016

Sure, I can separate them. Just not right now. ;)

@markelog
Copy link
Member

cool, thanks

@mgol mgol mentioned this issue Nov 2, 2016
Closed
@mgol mgol changed the title Hide jQuery.camelCase, separate its use cases. Separate camelCasing logic between Data & CSS Nov 2, 2016
@mgol
Copy link
Member Author

mgol commented Nov 2, 2016

@markelog Done.

@mgol mgol added Data and removed Data CSS labels Nov 2, 2016
mgol added a commit to mgol/jquery that referenced this issue Apr 17, 2019
@mgol
Core: Separate data & css/effects camelCase implementations
d97ecef 
The camelCase implementation used by the data module no longer turns `-ms-foo`
into `msFoo` but to `MsFoo` now. This is because `data` is supposed to be
a generic utility not specifically bound to CSS use cases.

Fixes jquerygh-3355
mgol added a commit to mgol/jquery that referenced this issue Apr 17, 2019
@mgol
Data: Separate data & css/effects camelCase implementations
821d23f 
The camelCase implementation used by the data module no longer turns `-ms-foo`
into `msFoo` but to `MsFoo` now. This is because `data` is supposed to be
a generic utility not specifically bound to CSS use cases.

Fixes jquerygh-3355
@mgol mgol mentioned this issue Apr 17, 2019
Merged
3 tasks
@mgol
Copy link
Member Author

mgol commented Apr 17, 2019

PR: #4365

mgol added a commit to mgol/jquery that referenced this issue Apr 23, 2019
@mgol
Data: Separate data & css/effects camelCase implementations
fe1db84 
The camelCase implementation used by the data module no longer turns `-ms-foo`
into `msFoo` but to `MsFoo` now. This is because `data` is supposed to be
a generic utility not specifically bound to CSS use cases.

Fixes jquerygh-3355
mgol added a commit that referenced this issue Apr 29, 2019
@mgol
Data: Separate data & css/effects camelCase implementations
8fae212 
The camelCase implementation used by the data module no longer turns `-ms-foo`
into `msFoo` but to `MsFoo` now. This is because `data` is supposed to be
a generic utility not specifically bound to CSS use cases.

Fixes gh-3355
Closes gh-4365
@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Behavior Change Data Has Pull Request
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Data: Separate data & css/effects camelCase implementations mgol/jquery
2 participants
@markelog @mgol