Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jQuery.camelCase #3384

Closed
mgol opened this issue Nov 2, 2016 · 2 comments
Closed

Deprecate jQuery.camelCase #3384

mgol opened this issue Nov 2, 2016 · 2 comments
Assignees
@mgol
Labels
Blocker Core Has Pull Request
Milestone
3.3.0

Comments

@mgol
Copy link
Member

@mgol mgol commented Nov 2, 2016

Description

We should hide jQuery.camelCase. It's an undocumented, private method which doesn't make sense to be available externally as it contains a CSS-only quirk that replaces -ms- to ms-. Rather than fixing it it's better to just remove it.

Theoretically we could do it in any minor release but since it's been semi-public for so long it's better to wait, especially that code around it will have to change in 4.0 anyway because of #3355.

Link to test case

N/A
@mgol mgol added the Core label Nov 2, 2016
@mgol mgol added this to the 4.0.0 milestone Nov 2, 2016
@mgol mgol self-assigned this Nov 2, 2016
@mgol mgol mentioned this issue Nov 2, 2016
Closed
@nltncsr
Copy link
Contributor

@nltncsr nltncsr commented Mar 27, 2017

I'm starting to contribute and I'd like to help on this one 😄
Do you think it's a good choice to move the function to src/var/ in its own module and import it wherever is needed, @mgol?
nltncsr added a commit to nltncsr/jquery that referenced this issue Apr 2, 2017
@nltncsr
Core: make camelCase function available only for internal usage
6c89a6e 
Move camelCase function from jQuery to an exclusive module and inject it
wherever is needed, modifying only where it is called.

Fixes jquerygh-3384
This was referenced Apr 2, 2017
Closed
Closed
nltncsr added a commit to nltncsr/jquery that referenced this issue Apr 3, 2017
@nltncsr
Tests: move unit tests mentioning the deprecated jQuery.camelCase
e68003f 
Move its single exclusive unit test from the core testing module to the
deprecated, and adapt other unit tests that inside makes use of jQuery.camelCase
to not rely on it.

Fixes jquerygh-3384
Closes jquerygh-3604
@timmywil timmywil changed the title Hide jQuery.camelCase Deprecate jQuery.camelCase, hide in 4.0 Apr 3, 2017
@timmywil timmywil modified the milestones: 3.3.0, 4.0.0 Apr 3, 2017
@timmywil timmywil added the Blocker label Jun 19, 2017
@mgol
Copy link
Member Author

@mgol mgol commented Nov 26, 2017

PR in progress is at #3604.
timmywil added a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@nltncsr @timmywil
Core: make camelCase function available only for internal usage
Verified
This commit was signed with a verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about signing commits
4e35997 
Close jquerygh-3604
Fixes jquerygh-3384
timmywil added a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@timmywil
[Core] adjust data tests to ensure proper camelCasing
Verified
This commit was signed with a verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about signing commits
4b0c654 
- Add back camelCase to the public object (deprecate not remove)
Ref jquery#3384
timmywil added a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@timmywil
Core: adjust data tests to ensure proper camelCasing
Verified
This commit was signed with a verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about signing commits
b22a03c 
- Add back camelCase to the public object (deprecate not remove)
Ref jquery#3384
@timmywil timmywil mentioned this issue Dec 4, 2017
Closed
4 of 4 tasks complete
@timmywil timmywil closed this in 64a2892 Jan 8, 2018
timmywil added a commit that referenced this issue Jan 8, 2018
@timmywil
Core: adjust data tests to ensure proper camelCasing
Verified
This commit was signed with a verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about signing commits
Loading status checks…
775caeb 
- Add back camelCase to the public object (deprecate not remove)
Ref #3384
@mgol mgol changed the title Deprecate jQuery.camelCase, hide in 4.0 Deprecate jQuery.camelCase Apr 24, 2018
@mgol mgol mentioned this issue Apr 24, 2018
Closed
1 of 2 tasks complete
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Blocker Core Has Pull Request
Projects
None yet
Milestone
3.3.0
Linked pull requests

Successfully merging a pull request may close this issue.

Fixes #3384: deprecate jQuery.camelCase
3 participants
@timmywil @mgol @nltncsr