Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jQuery.camelCase #3384

Closed
mgol opened this issue Nov 2, 2016 · 2 comments
Closed

Deprecate jQuery.camelCase #3384

mgol opened this issue Nov 2, 2016 · 2 comments
Assignees
@mgol
Labels
Blocker Core Has Pull Request
Milestone
3.3.0

Comments

@mgol
Copy link
Member

mgol commented Nov 2, 2016

Description

We should hide jQuery.camelCase. It's an undocumented, private method which doesn't make sense to be available externally as it contains a CSS-only quirk that replaces -ms- to ms-. Rather than fixing it it's better to just remove it.

Theoretically we could do it in any minor release but since it's been semi-public for so long it's better to wait, especially that code around it will have to change in 4.0 anyway because of #3355.

Link to test case

N/A
@mgol mgol added the Core label Nov 2, 2016
@mgol mgol added this to the 4.0.0 milestone Nov 2, 2016
@mgol mgol self-assigned this Nov 2, 2016
@mgol mgol mentioned this issue Nov 2, 2016
Closed
@nltncsr
Copy link
Contributor

nltncsr commented Mar 27, 2017

I'm starting to contribute and I'd like to help on this one 😄
Do you think it's a good choice to move the function to src/var/ in its own module and import it wherever is needed, @mgol?

This was referenced Apr 2, 2017
Closed
Closed
@timmywil timmywil changed the title Hide jQuery.camelCase Deprecate jQuery.camelCase, hide in 4.0 Apr 3, 2017
@timmywil timmywil modified the milestones: 3.3.0, 4.0.0 Apr 3, 2017
@mgol
Copy link
Member Author

mgol commented Nov 26, 2017

PR in progress is at #3604.

timmywil pushed a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@nltncsr @timmywil
Core: make camelCase function available only for internal usage
4e35997 
Close jquerygh-3604
Fixes jquerygh-3384
timmywil added a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@timmywil
[Core] adjust data tests to ensure proper camelCasing
4b0c654 
- Add back camelCase to the public object (deprecate not remove)
Ref jquery#3384
timmywil added a commit to timmywil/jquery that referenced this issue Dec 4, 2017
@timmywil
Core: adjust data tests to ensure proper camelCasing
b22a03c 
- Add back camelCase to the public object (deprecate not remove)
Ref jquery#3384
@timmywil timmywil mentioned this issue Dec 4, 2017
Closed
4 tasks
timmywil added a commit that referenced this issue Jan 8, 2018
@timmywil
Core: adjust data tests to ensure proper camelCasing
775caeb 
- Add back camelCase to the public object (deprecate not remove)
Ref #3384
@mgol mgol changed the title Deprecate jQuery.camelCase, hide in 4.0 Deprecate jQuery.camelCase Apr 24, 2018
@mgol mgol mentioned this issue Apr 24, 2018
Closed
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Blocker Core Has Pull Request
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Fixes #3384: deprecate jQuery.camelCase timmywil/jquery
3 participants
@timmywil @mgol @nltncsr