Deprecate jQuery.nodeName, remove in 4.0

[mgol]

Description

jQuery.nodeName is another undocumented utility function that's exposed on the jQuery object. We should remove it (probably in 4.0 as it's been there for a long time).

Link to test case

https://jsfiddle.net/o648k3ga/1/

[timmywil]

If we want to remove it in 4.0, we should deprecate in 3.2.

[mgol]

We can't deprecate something that's not documented. :) It's more than deprecated.

[timmywil]

@mgol I'd still like to give notice. We're doing the same for other undocumented functions that we plan on removing. While not required, you might call it courteous.

[karan-96]

Hello . i think ,to fix up this issue, jquery.nodeName function should be removed from src/core.js and added to src/deprecated.js. Correct me if i am wrong or if i am missing something.Can i take up this issue and work with this approach?

[timmywil]

@karan-96 That would be great! You'll find information on how to contribute here, with info on commits and PRs here. As far as the required work for this issue, that should be all the work needed for jQuery core. We'll also want to add a warning to the jQuery migrate plugin.

[dmethvin]

Just to clarify what has to be done here, I know it's got a PR at gh-3505 but we have to eliminate internal calls in order to warn about it in jQuery Migrate.

• Create an internal nodeName and put it in src/var/nodeName.js
• Change all internal calls to jQuery.nodeName to our new nodeName function
• Expose the internal nodeName as jQuery.nodeName in deprecated.js

Does that sound right to everyone?

[mgol]

@dmethvin yes, that's exactly what I said in #3505 (comment) a few days ago. :)

[mgol]

(although it seems it doesn't have to be a var-module in case of an exported function)

[dmethvin]

@mgol oh sorry, I missed that!