jQuery.fx.tick insufficiently guards against timer queue manipulation #3497
Comments
preethi26
added a commit
to preethi26/jquery
that referenced
this issue
Jan 16, 2017
…Handled repeated execution of animation in first tick. Fixes jquery#3497.
preethi26
added a commit
to preethi26/jquery
that referenced
this issue
Jan 16, 2017
…Handled repeated execution of animation in first tick. Fixes jquery#3497. corrected syntax error Fixes jquery#3497 Fixed. jquery#3497
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Description
jQuery.fx.tickexecutes each queued timer in turn, maintaining its place when it removes a finished animation. However,.stopand.finishcan also remove timers from the queue, and when invoked whiletickis iterating (i.e., from animation callbacks) can cause it to lose its place, skipping over one or more animations. This is often harmless (since the animation is revisited in the next tick), but can introduce visible stutter or (in a pathological case that I didn't bother demonstrating) starve an animation outright.Additionally, because
tickiterates to the end of the queue, new animations get processed twice in their first tick.We should fix both by making the three functions more aware of and cooperative with each other.
Link to test cases
The text was updated successfully, but these errors were encountered: