Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate auto-appending px in 3.4.0? #4009

Closed
mgol opened this issue Mar 13, 2018 · 1 comment
Closed

Deprecate auto-appending px in 3.4.0? #4009

mgol opened this issue Mar 13, 2018 · 1 comment
Labels
CSS

Comments

@mgol
Copy link
Member

mgol commented Mar 13, 2018

Description

In 4.0 I plan to take a stab at #2795. I think, though, we should try to deprecate auto-adding px earlier than that. This may not require changes in jQuery itself but on the API pages & in Migrate but I'd like to discuss the approach before doing the work.

One question - do we want to deprecate auto-adding px altogether or just for the properties we will stop auto-adding for? (i.e. not some most common ones like width) Deprecating all of that would go towards the ideal goal but might trigger warnings on the vast majority of projects so perhaps it'd be less invasive to not do it on the ones we will auto-fix.

Link to test case

N/A
@mgol mgol added this to the 3.4.0 milestone Mar 13, 2018
@dmethvin dmethvin mentioned this issue Mar 19, 2018
Closed
@mgol mgol removed the Needs review label Mar 19, 2018
mgol added a commit to mgol/jquery that referenced this issue Apr 23, 2018
@mgol
CSS: Don't automatically add "px" to properties except for a few exce…
419bd1d 
…ptions

Fixes jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 23, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
ce8b9b2 
Fixes jquerygh-2795
Ref jquerygh-4009
@mgol mgol mentioned this issue Apr 23, 2018
Closed
4 tasks
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
020119c 
Fixes jquerygh-2795
Ref jquerygh-4009
@mgol mgol mentioned this issue Apr 24, 2018
Merged
4 tasks
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
49d770a 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
a1c0a1e 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
096afcf 
Fixes jquerygh-2795
Ref jquerygh-4009
@mgol
Copy link
Member Author

mgol commented Apr 24, 2018

We have a migrate ticket ready so this can be closed; there's nothing to do in Core for this deprecation code-wise.

@mgol mgol closed this as completed Apr 24, 2018
@mgol mgol removed this from the 3.4.0 milestone Apr 24, 2018
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
a7ffc1f 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
cd5c18a 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
b15c36b 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
fbe70d2 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
730ca9e 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
dd4c3ad 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
55af87f 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 25, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
0d912da 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 25, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
9dcc840 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 25, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
91551c9 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 30, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
c834f76 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Apr 30, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
15fe27b 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue May 2, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
1cda578 
Fixes jquerygh-2795
Ref jquerygh-4009
mgol added a commit to mgol/jquery that referenced this issue Jun 4, 2018
@mgol
CSS: Don't automatically add "px" to properties with a few exceptions
03e9dba 
Fixes jquerygh-2795
Ref jquerygh-4009
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CSS
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgol