New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate auto-appending `px` in 3.4.0? #4009

Closed
mgol opened this Issue Mar 13, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@mgol
Member

mgol commented Mar 13, 2018

Description

In 4.0 I plan to take a stab at #2795. I think, though, we should try to deprecate auto-adding px earlier than that. This may not require changes in jQuery itself but on the API pages & in Migrate but I'd like to discuss the approach before doing the work.

One question - do we want to deprecate auto-adding px altogether or just for the properties we will stop auto-adding for? (i.e. not some most common ones like width) Deprecating all of that would go towards the ideal goal but might trigger warnings on the vast majority of projects so perhaps it'd be less invasive to not do it on the ones we will auto-fix.

Link to test case

N/A

@mgol mgol added this to the 3.4.0 milestone Mar 13, 2018

@mgol mgol removed the Needs review label Mar 19, 2018

mgol added a commit to mgol/jquery that referenced this issue Apr 23, 2018

@mgol

This comment has been minimized.

Member

mgol commented Apr 24, 2018

We have a migrate ticket ready so this can be closed; there's nothing to do in Core for this deprecation code-wise.

@mgol mgol closed this Apr 24, 2018

@mgol mgol removed this from the 3.4.0 milestone Apr 24, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.