Tests: Exclude tests based on compilation flags, not API presence #5069
Comments
|
PR for |
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Closes jquerygh-5046
|
Reopening until the |
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
|
|
mgol
added a commit
to mgol/jquery
that referenced
this issue
Jun 28, 2022
Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Fixes jquerygh-5069 Ref jquerygh-5046 (partially cherry picked from commit fae5fee)
mgol
added a commit
that referenced
this issue
Jul 12, 2022
…x version) Introduces a new test API, `includesModule`. The method returns whether a particular module like "ajax" or "deprecated" is included in the current jQuery build; it handles the slim build as well. The util was created so that we don't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. Closes gh-5071 Fixes gh-5069 Ref gh-5046 (partially cherry picked from commit fae5fee)
This was referenced Jul 12, 2022
|
All PRs have landed; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Description
We shouldn't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. This has already happened when we removed
String.prototype.trimonmasterwithout its tests and nothing failed since the tests were being guarded by a check for the existence of this method.Tests should detect which modules are included in the current compilation by inspecting
jQuery.fn.jqueryand decide which tests to run based on that.Link to test case
The text was updated successfully, but these errors were encountered: