Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector: Firefox 114 fails the ":lang respects escaped backslashes" selector test #5271

Closed
mgol opened this issue Jun 19, 2023 · 4 comments · Fixed by #5277
Closed

Selector: Firefox 114 fails the ":lang respects escaped backslashes" selector test #5271

mgol opened this issue Jun 19, 2023 · 4 comments · Fixed by #5277
Assignees
Milestone

Comments

@mgol
Copy link
Member

mgol commented Jun 19, 2023

Description

Firefox 114 fails the ":lang respects escaped backslashes" selector test. We should fix it before releasing 3.7.1.

Link to test case

https://swarm.jquery.org/result/4756651

Screenshot 2023-06-20 at 00 12 52
@mgol mgol added the Selector label Jun 19, 2023
@mgol mgol added this to the 3.7.1 milestone Jun 19, 2023
@ewolfman

This comment was marked as off-topic.

@mgol

This comment was marked as off-topic.

@mgol
Copy link
Member Author

mgol commented Jun 21, 2023

I submitted a bug report to Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1839747

mgol added a commit to mgol/jquery that referenced this issue Jun 26, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Fixes jquerygh-5271
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref w3c/csswg-drafts#8720 (comment)
@mgol
Copy link
Member Author

mgol commented Jun 26, 2023

PR disabling the problematic test: #5277

@mgol mgol self-assigned this Jun 26, 2023
mgol added a commit that referenced this issue Jun 27, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Fixes gh-5271
Closes gh-5277
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref w3c/csswg-drafts#8720 (comment)
mgol added a commit that referenced this issue Jun 27, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Fixes gh-5271
Closes gh-5277
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref w3c/csswg-drafts#8720 (comment)

(cherry picked from commit 62b9a25)
mgol added a commit to jquery/sizzle that referenced this issue Sep 7, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Ref jquery/jquery#5271
Ref jquery/jquery#5277
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref w3c/csswg-drafts#8720 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants