Tests: Disable the ":lang respects escaped backslashes" test #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped. It is an intentional change as `:lang()` parameters are supposed to be valid BCP 47 strings. Therefore, we won't attempt to patch it. We'll keep this test here until other browsers match the behavior. Fixes jquerygh-5271 Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1 Ref w3c/csswg-drafts#8720 (comment)
mgol
added
Needs review
Tests
Discuss in Meeting
timmywil
approved these changes
Jun 27, 2023
mgol
removed
Discuss in Meeting
mgol
added a commit
that referenced
this pull request
Jun 27, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped. It is an intentional change as `:lang()` parameters are supposed to be valid BCP 47 strings. Therefore, we won't attempt to patch it. We'll keep this test here until other browsers match the behavior. Fixes gh-5271 Closes gh-5277 Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1 Ref w3c/csswg-drafts#8720 (comment) (cherry picked from commit 62b9a25)
mgol
added a commit
to jquery/sizzle
that referenced
this pull request
Sep 7, 2023
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped. It is an intentional change as `:lang()` parameters are supposed to be valid BCP 47 strings. Therefore, we won't attempt to patch it. We'll keep this test here until other browsers match the behavior. Ref jquery/jquery#5271 Ref jquery/jquery#5277 Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1 Ref w3c/csswg-drafts#8720 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Firefox 114+ no longer match on backslashes in
:lang(), even when escaped. It is an intentional change as:lang()parameters are supposed to be valid BCP 47 strings. Therefore, we won't attempt to patch it. We'll keep this test here until other browsers match the behavior.Fixes gh-5271
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1 Ref w3c/csswg-drafts#8720 (comment)
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com