Keep track of a hiding state for toggle based animations - Fixes #8685 #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| var tested, |
There was a problem hiding this comment.
shouldn't the var statement be the first statement inside this block (so before the defintion of the secondToggle() function..?
There was a problem hiding this comment.
jshint wanted the named function at the top - It probably wouldn't of complained right beneath the var statement, but the order of those two things is pretty inconsequential
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is targeted against master - 78b02ec should merge to the head of 1.8-stable as well. I'd love to see this in a 1.8 release