Keep track of a hiding state for toggle based animations - Fixes #8685 #1018

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@gnarf
Member

gnarf commented Nov 4, 2012

This is targeted against master - 78b02ec should merge to the head of 1.8-stable as well. I'd love to see this in a 1.8 release

+ });
+ }
+
+ var tested,

This comment has been minimized.

Show comment Hide comment
@staabm

staabm Nov 5, 2012

Contributor

shouldn't the var statement be the first statement inside this block (so before the defintion of the secondToggle() function..?

@staabm

staabm Nov 5, 2012

Contributor

shouldn't the var statement be the first statement inside this block (so before the defintion of the secondToggle() function..?

This comment has been minimized.

Show comment Hide comment
@gnarf

gnarf Nov 5, 2012

Member

jshint wanted the named function at the top - It probably wouldn't of complained right beneath the var statement, but the order of those two things is pretty inconsequential

@gnarf

gnarf Nov 5, 2012

Member

jshint wanted the named function at the top - It probably wouldn't of complained right beneath the var statement, but the order of those two things is pretty inconsequential

@gnarf gnarf closed this in c45f609 Nov 8, 2012

gnarf added a commit that referenced this pull request Nov 8, 2012

Keep track of a hiding state for toggle based animations - Fixes #8685
Closes gh-1018
(cherry picked from commit c45f609)

Conflicts:

	src/effects.js

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment