Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13855: line-height animations #1265

Closed
wants to merge 3 commits into from
Closed

Conversation

gibson042
Copy link
Member

cc @dmethvin @gnarf37

As it turns out, we can fix line-height animations after all.

I'd also like to land an analog in 1.10.0, but it could wait for 1.10.1 if that's deemed to be the better approach since this missed beta 1.

   raw     gz Sizes                                                            
242403  71913 dist/jquery.js                                                   
 83348  29192 dist/jquery.min.js                                               

   raw     gz Compared to master @ 1debe49ac7d9379ede44e873e4a2ebaa10dfb0b6    
   +46    +33 dist/jquery.js                                                   
   -12     -9 dist/jquery.min.js

@gnarf
Copy link
Member

gnarf commented May 11, 2013

👍 looks solid, ❤️ that createTweens -> jQuery.map( props, createTween, animation )

@dmethvin
Copy link
Member

lgtm too!

@gibson042 gibson042 closed this in 3971c2e May 14, 2013
gibson042 added a commit that referenced this pull request May 14, 2013
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants