Fix #14422 and add more thorough check for CSP violations #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Beware of CSP restrictions (https://developer.mozilla.org/en/Security/CSP) | ||
| div.setAttribute( eventName, "t" ); | ||
| support[ i + "Bubbles" ] = div.attributes[ eventName ].expando === false; | ||
| } |
There was a problem hiding this comment.
Why make these support.js changes? They don't seem to relate to testing CSP.
There was a problem hiding this comment.
See this for more info.
There was a problem hiding this comment.
I probably should note, that new assertion actually miss Firefox thing, as it turns out, Firefox do not send csp reports if error happen in the iframe.
There was a problem hiding this comment.
Seriously?!? What if we used window.open for this one test?
Edit: Nevermind my fevered ramblings; obviously popup blockers kill that thought.
|
@gibson042 done |
|
👍 |
markelog
added a commit
that referenced
this pull request
Nov 7, 2013
|
Landed via 9e3d0f3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @gibson042, @dmethvin