Fix #14340. Remove remnants of oldIE from unit tests. #1425
Conversation
|
I've run the test suite in IE9, IE10, Safari 7, Safari 5.1, Opera 12.16, Firefox 25 and Chrome 30 and only Chrome errored on one test but it's the same on master. So it should be safe to merge. |
| // "When html is within brackets, do not recognize as html." ); | ||
| equal( jQuery( "element:not(<div></div>)" ).length, 0, | ||
| "When html is within parens, do not recognize as html." ); | ||
| equal( jQuery( "\\<div\\>" ).length, 0, "Ignore escaped html characters" ); |
There was a problem hiding this comment.
These should be checked in 1.x-master too; they look like the kind of selector now working in Sizzle.
There was a problem hiding this comment.
("element [attribútum = '
There was a problem hiding this comment.
@gibson042 Do you want it in a separate commit then?
There was a problem hiding this comment.
Yeah, a separate commit would let us handle the parsing logic in isolation. If it is good on both branches, I'd just push directly.
There was a problem hiding this comment.
@gibson042 I've checked on modern browsers and IE6-9 and it works so I've pushed it on both branches.
|
-TestIframe ("Offset / relatív", "relatív", funkció ($) { |
| @@ -58,10 +58,6 @@ test("css(String|Hash)", function() { | |||
| jQuery("#foo").css({"opacity": ""}); | |||
| equal( jQuery("#foo").css("opacity"), "1", "Assert opacity is 1 when set to an empty String" ); | |||
|
|
|||
| equal( jQuery("#empty").css("opacity"), "0", "Assert opacity is accessible via filter property set in stylesheet in IE" ); | |||
| jQuery("#empty").css({ "opacity": "1" }); | |||
| equal( jQuery("#empty").css("opacity"), "1", "Assert opacity is taken from style attribute when set vs stylesheet in IE with filters" ); | |||
There was a problem hiding this comment.
I'd like to keep these too; they're harmless but will maintain expect-count parity.
|
All comments by @gibson042 addressed. |
|
👍 |
No description provided.