New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14340. Remove remnants of oldIE from unit tests. #1425

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mgol
Member

mgol commented Nov 10, 2013

No description provided.

mgol added a commit to mgol/jquery that referenced this pull request Nov 10, 2013

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Nov 10, 2013

Member

I've run the test suite in IE9, IE10, Safari 7, Safari 5.1, Opera 12.16, Firefox 25 and Chrome 30 and only Chrome errored on one test but it's the same on master. So it should be safe to merge.

Member

mgol commented Nov 10, 2013

I've run the test suite in IE9, IE10, Safari 7, Safari 5.1, Opera 12.16, Firefox 25 and Chrome 30 and only Chrome errored on one test but it's the same on master. So it should be safe to merge.

Show outdated Hide outdated test/unit/core.js
Show outdated Hide outdated test/unit/offset.js
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 10, 2013

-TestIframe ("Offset / relatív", "relatív", funkció ($) {

ghost commented Nov 10, 2013

-TestIframe ("Offset / relatív", "relatív", funkció ($) {

mgol added a commit to mgol/jquery that referenced this pull request Nov 10, 2013

Show outdated Hide outdated test/unit/css.js

mgol added a commit to mgol/jquery that referenced this pull request Nov 10, 2013

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Nov 10, 2013

Member

All comments by @gibson042 addressed.

Member

mgol commented Nov 10, 2013

All comments by @gibson042 addressed.

mgol added a commit to mgol/jquery that referenced this pull request Nov 10, 2013

mgol added a commit to mgol/jquery that referenced this pull request Nov 10, 2013

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Nov 11, 2013

Member

👍

Member

gibson042 commented Nov 11, 2013

👍

@mgol mgol closed this in 4b39a82 Nov 11, 2013

@mgol mgol deleted the mgol:old_support branch Nov 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment