Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14545. In-body STYLE element returns nonzero dimensions #1445

Closed
wants to merge 8 commits into from
Closed

Fixes #14545. In-body STYLE element returns nonzero dimensions #1445

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c6f3748
Fixes #14545. In-body STYLE element returns nonzero dimensions
grisendo Nov 21, 2013
4200c3d
Strict comparision typo
grisendo Nov 21, 2013
df3bca7
Lint warning
grisendo Nov 21, 2013
e5109a7
Whitespaces changed to tabs
grisendo Nov 21, 2013
dd1acaa
Script/style width/height size moved out from getWidthOrHeight
grisendo Nov 21, 2013
e0b7d37
Unit test for style/script width/height
grisendo Nov 21, 2013
5a9db21
Semicolon after instruction
grisendo Nov 21, 2013
b114a44
Added nodes to #qunit-fixture in test
grisendo Nov 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,14 @@ function getWidthOrHeight( elem, name, extra ) {
var valueIsBorderBox = true,
val = name === "width" ? elem.offsetWidth : elem.offsetHeight,
styles = getStyles( elem ),
isBorderBox = jQuery.css( elem, "boxSizing", false, styles ) === "border-box";
isBorderBox = jQuery.css( elem, "boxSizing", false, styles ) === "border-box",
elemNodeName = elem.nodeName.toLowerCase();

// In HTML5, it is now valid to have style tags outside the head tag.
// See http://bugs.jquery.com/ticket/14545
if (elemNodeName === "script" || elemNodeName === "style") {
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces → tabs


// some non-html elements return undefined for offsetWidth, so check for null/undefined
// svg - https://bugzilla.mozilla.org/show_bug.cgi?id=649285
Expand Down