New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE XHR method polyfill #1459
IE XHR method polyfill #1459
Conversation
This won't work because we don't support ActiveXObject in the 2.x branch. I'm backing out a commit I made that implied we did. |
Sorry, ignore that comment. |
@michaelpapworth could please rebase this with current |
@michaelpapworth Please sing our CLA. Also, you shouldn't base your patch on a release tag but on a pure |
@mzgol I've signed the CLA and re-based my branch against 1.x-master. Thanks |
@michaelpapworth There's still a lot of noise here. Look at the commits tab - there should be only one commit and it should be yours. Since you based your patch on the release tag, there are all this unnecessary EDIT: you should revert all this three Dave commits and then squash everything using |
I've had some issues trying to squash these, I've decided for the sake of a few lines of code I'll start over and submit a new pull request (#1460) |
@michaelpapworth You didn't have to close it, you could re-create your patch on a separate branch and then reset your branch to it (with |
@mzgol I'm sorry but I'm relatively new to GitHub and unfamiliar with the command line Kung Fu that goes with it. Should I continue with the new pull and abandon this one? |
@michaelpapworth Yes, since you've already created one, let's continue there. |
At line 30 of /src/ajax/xhr.js I've added a prefilter which resolves bug #13240, my branch taken from the 1.11.0-beta2 tag since the issue only effects IE<9 therefore not required as part of 2.x