New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid use of Object.keys() [corrected] #1472
Conversation
Did you perf test the change? Usually You also need to open a bugtracker ticket |
An associated ticket on the bug tracker is necessary. For more information, see the contributing guidelines. |
Also, I think you meant |
/cc @rwaldron |
Thanks for comments! I opened a ticket in bugtracker. http://bugs.jquery.com/ticket/14659 @staabm Thanks for confirmation. No errors are found in Test Suite. Also I verified that event listeners were removed in my simple test case. |
The change works fine, but I don't like the rationale given in the ticket. @K-ori considering my response here: http://bugs.jquery.com/ticket/14659#comment:1, can you provide evidence of a performance improvement? |
[Performance] [File size] master branch
patched branch
Compared to master @ 537e9ce
|
It looks like we're just backing out the change from c1b8edf, which is fine with me if it saves bytes. |
Avoid use of Object.create() to keep code consistency for iteration of object properties.