Support: Simplify the box-sizing test #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't require body in the support.boxSizing test.
| @@ -33,6 +33,11 @@ define([ | |||
| div.cloneNode( true ).style.backgroundClip = ""; | |||
| support.clearCloneStyle = div.style.backgroundClip === "content-box"; | |||
|
|
|||
| // Support: Firefox<29, Android 2.3 | |||
| // Vendor-prefix box-sizing | |||
| support.boxSizing = style.boxSizing === "" || style.MozBoxSizing === "" || | |||
There was a problem hiding this comment.
Isnt this support test no longer lazy as of now?
There was a problem hiding this comment.
Yes but it shouldn't cause additional layouts. The style is from the <a> element.
There was a problem hiding this comment.
And it'll get even shorter once we remove MozBoxSizing. Probably not before 2.3, though, considering how crucial this is and that Firefox 24 ESR - the last one to have prefixed box-sizing - will be supported until the end of July.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require body in the support.boxSizing test.
I don't know why the test was so complicated, it seems like it was done on purpose which suggests that some implementation could pass the test from this PR but would fail the current one. However, all our supported browsers match what's expected for
support.boxSizingso it seems if there was ever any issue with that, it's now resolved.Apart from not requiring a body (and layout), this PR also saves 26 bytes.