Fix jQuery.noConflict #1606
Closed
Fix jQuery.noConflict #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was no jQuery defined at all in the window, using `jQuery.noConflict` properly remove the `jQuery` and `$` references, but let them as `undefined` properties. This fix, completely remove the keys. In the chrome console for example, the `$` reference, is then properly reset to the chrome console `$` utility.
|
Needs:
|
|
We could do this for master at this point I think but it still can't be done for 1.x-master because oldIE doesn't allow |
+1 |
Agreed. |
|
Yeah, I'd be all for the patch if we didn't have 1.x. For now it's better to not change it. |
|
We're leaving as-is so the two branches will be consistent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was no jQuery defined at all in the window, using
jQuery.noConflictproperly remove thejQueryand$references, but let them asundefinedproperties.This fix, completely remove the keys. In the chrome console for example, the
$reference, is then properly reset to the chrome console$utility.