Manipulation: support data-URI scripts insertion #1888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add spaces around quotes in jQuery("#qunit-fixture")and window["testFoo"] |
|
In CLA, If your real name not "rhyzx" you have to write a correct one. |
rhyzx
force-pushed
the
fix-data-uri-script-insertion
branch
from
5fd5e6e
to
d091195
Compare
|
updated, and i've signed up a new CLA with my realname, |
|
Sorry about this bureaucratic stuff, but name in CLA should match the commit author too. Could you change that? After that we're good to go |
|
With another thought: i could that for you, if you're okay with that |
rhyzx
force-pushed
the
fix-data-uri-script-insertion
branch
from
d091195
to
bdd5786
Compare
|
🐱 DONE |
|
Merged |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1887