Ticket: 8909 - $(element).data() will scan the attributes more times than needed.

[gnarf]

If you make more than one call to $(element).data() you end up having to loop over the attributes of the element looking for "data-" attributes every time you access it. I'd like to propose adding a simple flag in our private _data() that can stop us from having to check more than once...'

This pull attempts to correct that using a private data value to store when it has parsed the elements attribs.

http://bugs.jquery.com/ticket/8909

[dmethvin]

This looks like a good idea! It should make .data() a bit faster, the only drawback being if someone dynamically added a data- attr we wouldn't catch it. Seems like a small issue though.

[gnarf]

Honestly, it seems that there is no support for "updated" attribs at the moment so it would kind of make sense that later appended ones don't show up either... I mean, if you change .data('someKeyFromAttrib', newValue) it doesn't update the html or anything, and the getter always returns whatever it read the first time... It doesn't re-read if it already cached the value...

[dmethvin]

Yeah, it can get especially confusing if were to do $.data(elem, "abc") , $(elem).data("abc"), $.data(elem, "abc") because the middle call loads the cache. Oh well. It seems like this is a good idea in any case.

[dmethvin]

The pull looks good to me but I want to consult the jQuery Mobile team to be sure that this won't cause problems for them. They are set to use 1.6.3 as the base for their first release.

[rwaldron]

jQuery._data(elem needs space at ( e

[gnarf]

Great points @rwldrn - I'll re open when I've addressed these points and rebased