Manipulation: Respect script nomodule attribute in DOM manipulation #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR jquery#3869 added support for `<script type="module">` & some support for the `nomodule` attribute but with no tests for `nomodule` and with the attribute only respected on inline scripts. This commit adds support for source-based scripts as well. It also adds tests for `nomodule`, including making sure legacy browsers execute such scripts as they'd natively do - that's the whole point of `nomodule` scripts, after all. Fixes jquerygh-4281 Ref jquerygh-3871 Ref jquerygh-3869
|
|
gibson042
approved these changes
Jan 17, 2019
timmywil
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #3869 added support for
<script type="module">& some support forthe
nomoduleattribute but with no tests fornomoduleand with theattribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for
nomodule, includingmaking sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of
nomodulescripts, after all.Fixes gh-4281
Ref gh-3871
Ref gh-3869
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com- I don't think that's needed here.