Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upManipulation: Respect script nomodule attribute in DOM manipulation #4282
Conversation
mgol
added
the
Manipulation
label
Jan 17, 2019
mgol
added this to the 3.4.0 milestone
Jan 17, 2019
mgol
self-assigned this
Jan 17, 2019
mgol
added
the
Needs review
label
Jan 17, 2019
mgol
referenced this pull request
Jan 17, 2019
Closed
nomodule attribute is not respected on scripts with sources #4281
This comment has been minimized.
This comment has been minimized.
|
|
gibson042
approved these changes
Jan 17, 2019
timmywil
approved these changes
Jan 18, 2019
mgol
merged commit e4de8b4
into
jquery:master
Jan 21, 2019
mgol
deleted the
mgol:nomodule-src
branch
Jan 21, 2019
mgol
removed
the
Needs review
label
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mgol commentedJan 17, 2019
•
edited
Summary
PR #3869 added support for
<script type="module">& some support forthe
nomoduleattribute but with no tests fornomoduleand with theattribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for
nomodule, includingmaking sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of
nomodulescripts, after all.Fixes gh-4281
Ref gh-3871
Ref gh-3869
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com- I don't think that's needed here.