New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manipulation: Respect script nomodule attribute in DOM manipulation #4282

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@mgol
Copy link
Member

mgol commented Jan 17, 2019

Summary

PR #3869 added support for <script type="module"> & some support for
the nomodule attribute but with no tests for nomodule and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for nomodule, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of nomodule scripts, after all.

Fixes gh-4281
Ref gh-3871
Ref gh-3869

Checklist

Manipulation: Respect script nomodule attribute in DOM manipulation
PR #3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.

Fixes gh-4281
Ref gh-3871
Ref gh-3869

@mgol mgol added the Manipulation label Jan 17, 2019

@mgol mgol added this to the 3.4.0 milestone Jan 17, 2019

@mgol mgol self-assigned this Jan 17, 2019

@mgol mgol added the Needs review label Jan 17, 2019

@mgol

This comment has been minimized.

Copy link
Member Author

mgol commented Jan 17, 2019

+9 bytes.

@mgol mgol merged commit e4de8b4 into jquery:master Jan 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mgol mgol deleted the mgol:nomodule-src branch Jan 21, 2019

@mgol mgol removed the Needs review label Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment