Core: Remove deprecated jQuery APIs #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mgol
commented
Apr 17, 2019
| @@ -1753,9 +1729,6 @@ QUnit.test( "Do not throw on frame elements from css method (#15098)", function( | |||
|
|
|||
| assert.expect( !!appearanceName + !!transformName + 1 ); | |||
|
|
|||
| resetCssPropsFor( "appearance" ); | |||
| resetCssPropsFor( "transform" ); | |||
There was a problem hiding this comment.
This does make the test a little less isolated but it's already been that way since finalPropName has been refactored by @dmethvin to use an internal vendorProps map so we're not losing much here.
Another test can influence this one if it sets some transform- or appearance-related props. We can think if there's any way around that but, as I said, it's already an issue.
mgol
force-pushed
the
deprecated-removal
branch
from
50ec683
to
41c3233
Compare
|
Note to self: separate |
mgol
force-pushed
the
deprecated-removal
branch
from
41c3233
to
ec764e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-4056
Checklist
New tests have been added to show the fix or feature works