Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7641: .animate() should accept "auto" and "" (empty string) values #515

Closed
wants to merge 1 commit into from

Conversation

louisremi
Copy link
Contributor

This PR fixes a "patchwelcome" bug in 10 short lines of code.
Unit-tests included.

http://bugs.jquery.com/ticket/7641 (was "patchwelcome", I just reopened it)

@timmywil
Copy link
Member

I'm a little concerned about this because although this adds some support for these values, they can never be fully supported. @gnarf37 also brought up a good point. css animations do not support these values.

@dmethvin
Copy link
Member

If something is "kinda" supported, you can bet we'll get plenty of bug reports for the times when it doesn't work. Can we defer this item until animate is refactored in 1.8? We can mark it for 1.8-discuss in the tracker. Sound good?

@louisremi
Copy link
Contributor Author

Please bear in mind that the limitations are the same when we animate from "auto" and to "auto".
This patch doesn't introduce new limitations to the API, there will be no new warning to add to the documentation.

I've actually queried the bug tracker with "auto" and "animate" keywords, and I haven't found any bug currently open. I guess this means we haven't much problems with people animating from "auto". We will have equally few problems with people animating to "auto", because the logic is the same.

Regarding CSS3 transitions and animations, nowhere in the spec is written that "auto" shouldn't be supported. It is actually supported in chrome and there is an open and accepted bug for firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=571344

@dmethvin
Copy link
Member

dmethvin commented Dec 6, 2011

I'm closing this pull since it's gone stale but leaving the ticket open for discussion.

@dmethvin dmethvin closed this Dec 6, 2011
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants