Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12357: be more kind to non-browser environments #936

Closed
wants to merge 1 commit into from

Conversation

gibson042
Copy link
Member

Sizes - compared to master @ d57363e

    265210        (+6)  dist/jquery.js                                         
     93442        (+4)  dist/jquery.min.js                                     
     33432        (+1)  dist/jquery.min.js.gz

@mikesherov
Copy link
Member

Since we can't test this, can we at least add a comment to the code explaining this change?

@dmethvin
Copy link
Member

I need to be more curious. Remember c79a533 ? That was the "useless guard" that just got put back in, and I remember thinking, "Huh, wonder why that was there." Well if I had just looked at the blame and seen dc83072 it would have been clear.

@dmethvin dmethvin closed this Sep 27, 2012
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants