Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Ticket #12518 #958

Closed

Conversation

fracmak
Copy link

@fracmak fracmak commented Oct 15, 2012

removes an offsetWidth on focus/blur events for an <IE9 bug that caused a performance hit and replaces it with a try/catch block.

There was already a unit test in place to cover this.

This bug is tricky to trigger because you actually need an IE8 native browser in windows XP, not an IE9 in IE8 mode

@rwaldron
Copy link
Member

reviewing

@rwaldron rwaldron closed this Oct 15, 2012
@rwaldron rwaldron reopened this Oct 15, 2012
@rwaldron
Copy link
Member

Whoops! Sorry about that...

@rwaldron
Copy link
Member

cc @mikesherov

@mikesherov
Copy link
Member

Cool. Looking now.

@mikesherov
Copy link
Member

👍 LGTM

@dmethvin
Copy link
Member

/botio test

@jquerybot
Copy link

From: jQuery Bot.io


Received

Command cmd_test from @dmethvin received. Current queue size: 0

Live output at: http://swarm.jquery.org:8000/3daed2ba7944475/output.txt

@jquerybot
Copy link

From: jQuery Bot.io


Failed

Full output at http://swarm.jquery.org:8000/3daed2ba7944475/output.txt

Total script time: 0.11 mins

@fracmak
Copy link
Author

fracmak commented Oct 15, 2012

merge with master, no conflicts, want to try again?

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants