New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Ticket #12518 #958
Closed
fracmak
wants to merge
2
commits into
jquery:master
from
fracmak:ticket_12518_offsetwidth_trigger_ie8
Closed
Fixes Ticket #12518 #958
fracmak
wants to merge
2
commits into
jquery:master
from
fracmak:ticket_12518_offsetwidth_trigger_ie8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug that caused a performance hit
reviewing |
Whoops! Sorry about that... |
cc @mikesherov |
Cool. Looking now. |
👍 LGTM |
/botio test |
From: jQuery Bot.ioReceivedCommand cmd_test from @dmethvin received. Current queue size: 0 Live output at: http://swarm.jquery.org:8000/3daed2ba7944475/output.txt |
From: jQuery Bot.ioFailedFull output at http://swarm.jquery.org:8000/3daed2ba7944475/output.txt Total script time: 0.11 mins |
merge with master, no conflicts, want to try again? |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
… bug that caused a performance hit. Closes jquerygh-958
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes an offsetWidth on focus/blur events for an <IE9 bug that caused a performance hit and replaces it with a try/catch block.
There was already a unit test in place to cover this.
This bug is tricky to trigger because you actually need an IE8 native browser in windows XP, not an IE9 in IE8 mode