Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks found on the footer of articles #647

Closed
AchoArnold opened this issue Mar 30, 2015 · 2 comments
Closed

Permalinks found on the footer of articles #647

AchoArnold opened this issue Mar 30, 2015 · 2 comments

Comments

@AchoArnold
Copy link
Contributor

From the logs here, http://jenkins.jquery.com/job/stage.learn.jquery.com/lastBuild/console,

The footer of articles such as http://stage.learn.jquery.com/code-organization/dont-repeat-yourself/ have links to other articles given by URLs such as http://stage.learn.jquery.com/?page_id=4729 instead of a URL's like http://stage.learn.jquery.com/code-organization/feature-browser-detection/

Is this intentional?

@AchoArnold AchoArnold changed the title Links found on the footer of articles Permalinks found on the footer of articles Mar 30, 2015
@arthurvr
Copy link
Member

arthurvr commented Apr 5, 2015

https://github.com/jquery/jquery-wp-content/blob/master/themes/learn.jquery.com/content-page.php#L31

@scottgonzalez I didn't do any serious wordpress work for years, do you have an idea how to change these to echo to the normal links?

@sigorilla
Copy link
Contributor

Hi @arthurvr @najela
Instead of this code at line 31

<?php echo $next_prev_arr['next']->guid; ?>

we can use

<?php echo get_page_link( $next_prev_arr['next']->ID ); ?>

Also I will create PR in jquery/jquery-wp-content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants