Change QUnit fixture reset behavior #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On load, set clone qunit-fixture element and set config.fixture equal to that. Change the reset function to replace the entire qunit-fixture element with a deep copy of the clone. Essentially, cache a clean copy of the fixture node on load and replace subsequent fixture nodes with that. Added tests to check if properties on the fixture are cleared between tests.
|
Thanks, landed. |
jzaefferer
added a commit
that referenced
this pull request
Feb 29, 2012
…tfix. This reverts commit b9010d4. That change turned out to cause very sublte bugs in jQuery UI testsuites, where the browser form memory would cache values between testruns. Which doesn't happen with the previous reset implementation. Unfortunate, but not worth the trouble.
|
I had to revert this patch, as it caused very subtle trouble downstream in jQuery UI. The type of failure is bad enough that I don't want anyone else to experience that again, so have to change this (and #194) to "wontfix". I will update the documentation accordingly. For your particular case, just leave the fixture element as-is and use a wrapper or child. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change for issue #194
Essentially, cache a clean copy of
the fixture node on load and replace subsequent fixture nodes with that.
On load, clone qunit-fixture element and set config.fixture equal to
that. Change the reset function to replace the entire qunit-fixture
element with a deep copy of the clone.
Added tests to check if properties on the fixture are cleared between
tests.