Fix typos/usage: descendent => descendant #325
Conversation
cvrebert
commented
Mar 23, 2015
cvrebert
commented
|
Signed the CLA. |
| @@ -717,7 +717,7 @@ setDocument = Sizzle.setDocument = function( node ) { | |||
| hasCompare = rnative.test( docElem.compareDocumentPosition ); | |||
|
|
|||
| // Element contains another | |||
| // Purposefully does not implement inclusive descendent | |||
| // Purposefully does not implement inclusive descendant | |||
There was a problem hiding this comment.
This comment was arguably correct before, but inarguably bad. Can you just rewrite it to something like "purposefully self-exclusive"?
|
@gibson042 Done, rephrased the comment. |
|
Thanks. See http://contribute.jquery.org/CLA/status/?repo=sizzle&sha=f9792bd3e65676c1ed4b238ec38f5b0f8f9b678c for CLA problems and how to resolve them. I'd like to include this in the quickly-approaching release. |
|
I just signed it again for good measure. Don't know what's wrong with your bot... |
|
Seems like a bot issue indeed. cc @scottgonzalez @gnarf The chrome extension passes. |
|
There are two commits here, authored with the same name but different addresses. We require exact matches for both. I see them in our CLA signatures, but the one matching the second commit follows its addition to this PR, so the CLA checker didn't see it. Can you add a new commit to your branch ( Sorry for the inconvenience. I've added jquery/contribute.jquery.org#110 to make this easier in the future. |
Ref: http://www.oxforddictionaries.com/us/definition/english/descendant > The correct spelling for the noun meaning 'person descended from > a particular ancestor' is descendant, not -ent.
|
I rewrote the PR as a single fresh commit (with a new timestamp even), but the CLA check is still incorrectly failing... |
|
This failure is because you've signed the CLA with that email address twice. The CLA checker ignores duplicate signatures and the first signature has your name as "Christopher Rebert". It's fine to land this. |
