Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testswarm does not work with QUnit 2 #313

Closed
workmanw opened this issue Dec 8, 2016 · 0 comments
Closed

Testswarm does not work with QUnit 2 #313

workmanw opened this issue Dec 8, 2016 · 0 comments
Milestone
1.1.0

Comments

@workmanw
Copy link
Contributor

workmanw commented Dec 8, 2016 •
edited
Loading

The issue is you can no longer use QUnit.log = function() { };. Instead you must do QUnit.log(function() { }); I have confirmed the fix locally and I will submit a PR shortly. Trying to figure out the best avenue for version detection to allow for backwards compat.

Source: https://qunitjs.com/upgrade-guide-2.x/#removed-and-modified-qunit-methods-and-properties
workmanw pushed a commit to Batterii/testswarm that referenced this issue Dec 8, 2016
Fixing jquery#313. Restoring functionality with QUnit 2.x.
3a72d8d
@workmanw workmanw mentioned this issue Dec 8, 2016
Merged
leobalter pushed a commit that referenced this issue Dec 8, 2016
@workmanw @leobalter
scripts: Restoring functionality with QUnit 2.x.
6e90546 
Fixes gh-313
Closes gh-314
@Krinkle Krinkle added this to the 1.1.0 milestone Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@Krinkle @workmanw