For review: Added note about optional dependencies #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least `find . -name custom-sql` on the current codebase seems to indicate that `src/main/resources/META-INF/custom-sql` is currently the right directory
…URL extraction smarter; ignore lines with multiple links
# Conflicts: # discover/portal/articles/03-collaboration/03-social-networking/04-integrating-with-facebook-and-more.markdown
… previous commit)
# Conflicts: # lib/liferay-doc-utils.jar
…ray-docs into config-vs-cfg-pr380
…ntro LRDOCS-4006 wrote intros and reorganized es2015 tutorials
Review Liferay PRs
LRDOCS-3845 Improve Check Links
|
Looks good! |
This was referenced Jan 10, 2020
|
Ported the changes in sez11a#4754 and sez11a#4755 with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.liferay.com/browse/LRDOCS-4011