Fix issue where jobs without specified count caused panic. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was caused by the incorrect assumption that jobs with a count not set or set to 0 can not result in a deployment. This was incorrect as an undefined count will result in a default count of 1; or that jobs set to count=0 can be run and deployed to stage the job or disable it. Closes #87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was caused by the incorrect assumption that jobs with a count not set or set to 0 can not result in a deployment. This was incorrect as an undefined count will result in a default count of 1; or that jobs set to count=0 can be run and deployed to stage the job or disable it.
@mimato and @adamlc this should fix the issue you're seeing and also fixes previously unseen bugs in the deployment process. It has been tested with the following suite of jobs:
Closes #87