[mc_control] Correctly log plugin performances #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setup the plugin performance log after all plugins have been loaded - Avoid dangling references across resets by forcing the log entry to be re-added
gergondet
added a commit
that referenced
this pull request
Sep 6, 2023
Added --- - [bindings] Add bindings for ControllerClient (#384) - [mc_rtc] Allow to override existing log entries (#383) - [mc_rtc] Allow "chunky" XY plot updates (#386) - [mc_solver] ConstraintSet now has an update mechanism (#381) - [Samples: CoM] Support the Pepper robot Changes --- - [StabilizerTask] Improve force distribution and CoP horizon reference (#375) - [mc_rbdyn] Convex objects are now automatically updated (#385) - [mc_solver] Collision constraint automatically display distance arrows when the distance falls below the interaction distance (#381) Fixes --- - [bindings] Fix build for Cython >= 3.0.0 - [cmake] Fix issue with yaml-cpp >= 0.8.0 - [mc_control] Fix logging of plugin performances (#383) - [mc_observers] KinematicInertial uses function from state-observation (#388) - [mc_rbdyn] Fix loading of devices with canonical robots (#379) - [mc_rbdyn] Fix compilation with geos >= 3.12.0 - [Replay] Fix output replay on fixed-based robots - [Replay] Avoid precision issue when comparing controller timestep with replay timestep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one feature:
log.addLogEntrycan use theoverwrite = trueparameter to force an entry into the log even if it already existsIt also contains a fix to plugin performance logging. This was particularly problematic when the controller includes enough plugin to trigger a resize on the
plugins_before_/plugins_after_vectors since it would then access freed memory during logging.