Add ::clone() to sch::S_Object #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not the default yet and recent Boost requires it (constexpr in boost/maths)
The first version works thanks to copy ellision because the copy constructor for CD_Scene is broken. Rather than fixing CD_Scene (which afaik is not used outside of the tests?), we avoid relying on copy ellision for cloning the universes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a virtual clone method to S_Object so the objects can be copied from a pointer to
sch::S_ObjectThe method is tested by cloning the universe in the unit tests. It actually revealed an issue in the implementation of S_Polyhedron and STP_BV copy operators which is also fixed by this PR