Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCrypto is dead. Switch to PyCryptodome #501

Closed
wants to merge 56 commits into from
Closed

PyCrypto is dead. Switch to PyCryptodome #501

wants to merge 56 commits into from

Conversation

jnozsc
Copy link

@jnozsc jnozsc commented Sep 16, 2017

No description provided.

maebert and others added 30 commits September 17, 2014 08:35
Added how to ignore history appending for zsh
Fixed "-on today" option inclusive date parsing
…m being used. Now editing one entry results in "[1 entry modified]"
Fixed a bug. --edit now shows [1 entry modified] not [1 entries modified]
Handle situation where a specified jounal is not found.
Added basic logging feature to understand how is configuration loaded
doozr and others added 16 commits July 14, 2016 14:24
The keyring package broke backward compatibility in version 8.0 by
moving some keyring backends to another package, keyrings.alt, as
documented in the changelog [1].

This change broke behave tests which were trying to use
keyring.backends.file.PlaintextKeyring - no longer existing in keyring
package.

This commit adds the keyrings.alt package as dependency so that the
PlaintextKeyring class can be used.

[1] https://pythonhosted.org/keyring/history.html#id22
Add more recent Python versions including development branches and nightly build.
@jnozsc
Copy link
Author

jnozsc commented Sep 16, 2017

@maebert

@sigmap
Copy link

sigmap commented Mar 5, 2018

I hope this gets merged. It'd be a good temporary fix until 2.0

@tcyrus
Copy link

tcyrus commented Jan 1, 2019

I am currently unable to install jrnl[encrypted] due to pycrypto/pycrypto#218, which will not be fixed because the project is no longer maintained. Merging this should resolve this issue.

@tcyrus
Copy link

tcyrus commented Jan 26, 2019

If anybody is trying to install on Windows with PyCrypto, this solution worked for me:
pycrypto/pycrypto#218 (comment)

I hope this pull request gets merged since this would make installation a lot simpler on Windows.

@tcyrus
Copy link

tcyrus commented Jan 26, 2019

@maebert

@crookshanked
Copy link

Too bad about this not getting merged in. The above info seems to not fully work for me with the work around. It installs pycrypto, and then jrnl installs... creates the journal and encrypts... then asks for the password and errors saying pycrypto is not installed.

@micahellison micahellison added the encryption Encrypting/decrypting the journal label Jul 7, 2019
@wren
Copy link
Member

wren commented Jul 20, 2019

Hi, we switched away from PyCrypto in v2.0. Sorry that this didn't get merged in! Thank you for the PR anyway!

@wren wren closed this Jul 20, 2019
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
encryption Encrypting/decrypting the journal 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet