Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic logging feature to understand how is configuration loaded #305

Merged
merged 2 commits into from
Nov 9, 2014

Conversation

pcarranza
Copy link
Contributor

I've implemented some basic logging features when -d or --debug is added as an argument, it behaves like this:

$ jrnl -d I\'ve just committed code on jrnl to enable debug mode with logging
DEBUG    jrnl.cli     Reading configuration from file /home/myuser/.jrnl_config
DEBUG    jrnl.util    Configuration file /home/myuser/.jrnl_config read correctly
DEBUG    jrnl.cli     Using configuration {u'default_hour': 9, u'linewrap': 79, u'encrypt': False, u'default_minute': 0, u'tagsymbols': u'@', u'editor': u'vi', u'timeformat': u'%Y-%m-%d %H:%M', u'highlight': True, u'journals': {u'default': u'/home/myuser/journal.txt'}}
DEBUG    jrnl.cli     Using journal default
DEBUG    jrnl.cli     Using journal path /home/myuser/journal.txt
DEBUG    jrnl.cli     Appending raw line "I've just committed code on jrnl to enable debug mode with logging" to journal "default"
[Entry added to default journal]

Probably there is a lot more work to do with the logger, but it is a start

@pcarranza pcarranza mentioned this pull request Nov 6, 2014
@maebert
Copy link
Contributor

maebert commented Nov 7, 2014

Great work. Could you rebase this agains branch 2.0-rc1 though?

@pcarranza
Copy link
Contributor Author

Sure, np, do you want cherry pick to have it in both or just 2.0?

maebert added a commit that referenced this pull request Nov 9, 2014
Added basic logging feature to understand how is configuration loaded
@maebert maebert merged commit 1046c18 into jrnl-org:master Nov 9, 2014
@maebert
Copy link
Contributor

maebert commented Nov 9, 2014

Ah, I'm going to merge this and pick it for 2.0 myself. Thanks again for the contribution!

@pcarranza
Copy link
Contributor Author

Hey, thanks, did not had any time to do it.

I'll check later the implementation on 2.0.

One thing, if you want maybe we can release this update in homebrew, just ping me to update the formula.

@maebert
Copy link
Contributor

maebert commented Nov 10, 2014

Alright. I'll browse through some old issues and add some debug stuff that would have helped there, too, and then we can wrap it up as a really really last release before 2.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants